"Customize CSS" should not be in Command Palette for non-block themes

[MadtownLems]

Description

"Customize CSS" is available as a command palette function in the context of editing Template Parts, but it shouldn't be there (as that shouldn't be relevant to non-block themes). The good news is that it just seems to fail silently, but it shouldn't be present in the UI.

Step-by-step reproduction instructions

1. Have a non-block theme that uses Template Parts.
2. Access the Command Palette, and type 'CSS'. See that "Customize CSS" is listed

Screenshots, screen recording, code snippet

Environment info

Tested on 6.6.1, both without Gutenberg and with Gutenberg 19.1.0

Please confirm that you have searched existing issues in the repo.

• Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

• Yes

[rutviksavsani]

@MadtownLems Can you please specify the Theme where you found the issue. I tested it on Twenty Twenty One theme and was not able to reproduce it.

Thanks!

[MadtownLems]

Hi there! Unfortunately core doesn't maintain a theme that fits the description, but the kind of theme talked about here: https://gutenbergtimes.com/block-based-template-parts-for-classic-themes/

…

On Mon, Sep 2, 2024, 5:24 AM Rutvik Savsani ***@***.***> wrote: @MadtownLems <https://github.com/MadtownLems> Can you please specify the Theme where you found the issue. I tested it on Twenty Twenty One theme and was not able to reproduce it. Thanks! — Reply to this email directly, view it on GitHub <#64932 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHGYBLUO2M5SVEVBJM6HTLZUQ4HHAVCNFSM6AAAAABNMUDAUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRUGM3TMMJQHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[MadtownLems]

You may want to see #56007 for a similar problem and resolution.

@t-hamano fixed that one, and perhaps can do similar here?

[t-hamano]

I can't reproduce the problem 🤔

@MadtownLems

• Just to be sure, did you launch the command palette after accessing Apperance > Patterns > All template parts > any template part?
• Is the theme you're having problems with exposed to the theme directory?

[MadtownLems]

Yes, exact those steps to reproduce. No, not in the theme directory. I will revisit this week with more information. Thank you!

…

On Mon, Sep 2, 2024, 11:02 AM Aki Hamano ***@***.***> wrote: I can't reproduce the problem 🤔 @MadtownLems <https://github.com/MadtownLems> - Just to be sure, did you launch the command palette after accessing Apperance > Patterns > All template parts > any template part? - Is the theme you're having problems with exposed to the theme directory <https://wordpress.org/themes/>? — Reply to this email directly, view it on GitHub <#64932 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHGYBOCWMUJ5W5WBW7ZXOTZUSDZVAVCNFSM6AAAAABNMUDAUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVGAZTKMZSGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[MadtownLems]

Complete steps to reproduce:

1. Take Twenty Twenty One, and add template parts support, such as:

function add_block_template_part_support() { add_theme_support( 'block-template-parts' ); } add_action( 'after_setup_theme', 'add_block_template_part_support' );`

AND adding something to theme.json to register one:

`{
"$schema": "https://schemas.wp.org/trunk/theme.json",
"version": 3,
"settings": {
},
"templateParts": [
{
"name": "my-template-part",
"title": "My Template Part",
"area": "some-area"
}
]

}`

Once you do, you don't even need to do anything with Template Parts. Simply Add New Pattern, access the command palette, and find "Customize CSS" is now present

[t-hamano]

Thanks for the reply. I was able to reproduce this issue.

All that's needed to reproduce the issue seems to be to add a theme.json to the classic theme. Simply create a theme.json with an empty object ({}) in the Twenty Twenty-One theme and you'll be able to reproduce this issue.

[MadtownLems]

Thank you for confirming and for making the steps to reproduce even easier! I ran through what I believe are all the commands, and that was the only one that seemed out of place for our type of theme.

Until core stops adding it, I'm trying to figure out how to unregister it myself: #65021