Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUIC will need ssl_client_cert_callback implementation after PR #6699 has landed #6939

Open
shinrich opened this issue Jun 23, 2020 · 2 comments
Milestone

Comments

@shinrich
Copy link
Member

I do not see where to put the analogous callback in the QUIC code, so filing this issue for others to remember and add it in.

@maskit
Copy link
Member

maskit commented Jun 24, 2020

The callback function, ssl_client_cert_callback should be set in quic_init_client_ssl_ctx().

I don't have strong opinion on where to put the callback function but I'd follow the same way as other XSupport classes and move most code currently in the callback function to the XSupport class for this.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.

@github-actions github-actions bot added the Stale label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants