Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should allow control on whether default cert paths/files are included for verification #1525

Open
shinrich opened this issue Mar 1, 2017 · 2 comments
Assignees
Milestone

Comments

@shinrich
Copy link
Member

shinrich commented Mar 1, 2017

When creating the SSL_CTX for ATS initiating connections to origin, we always call SSL_CTX_set_default_verify_path which adds the default trusted root packages on the system. You can also set your own via settings, but the default case is also added.

For a reverse proxy, the default trusted root set is probably not desirable. You probably just want to verify that your origins are signed with your small set of trusted roots. Adding more trusted roots just allows for the possibility that you accept a cert signed by someone else entirely.

There are a couple options to fix this

  1. Add a new setting to ignore default trusted root
  2. Don't call SSL_CTX_set_default_verify_path if a CA file or CA directory is explicitly defined.
  3. The reverse proxy folks should just move the default trusted root files out of the way if they case (which is accidentally what we did).

No option is technically difficult, but probably worth a bit of discussion.

@shinrich shinrich self-assigned this Mar 1, 2017
@shinrich shinrich added the TLS label Mar 1, 2017
@shinrich
Copy link
Member Author

Still an issue in the code.

@zwoop zwoop added this to the 10.0.0 milestone May 22, 2019
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.

@github-actions github-actions bot added the Stale label Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants